Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19993#discussion_r159100390
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala 
---
    @@ -430,4 +433,45 @@ object ParamsSuite extends SparkFunSuite {
         require(copyReturnType === obj.getClass,
           s"${clazz.getName}.copy should return ${clazz.getName} instead of 
${copyReturnType.getName}.")
       }
    +
    +  /**
    +   * Checks that the class throws an exception in case both `inputCols` 
and `inputCol` are set and
    +   * in case both `outputCols` and `outputCol` are set.
    +   * These checks are performed only whether the class extends 
respectively both `HasInputCols` and
    --- End diff --
    
    only whether" -> "only when"


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to