Github user WeichenXu123 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20111#discussion_r159116537
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/BucketedRandomProjectionLSHSuite.scala
 ---
    @@ -98,6 +97,21 @@ class BucketedRandomProjectionLSHSuite
         MLTestingUtils.checkCopyAndUids(brp, brpModel)
       }
     
    +  test("BucketedRandomProjectionLSH: streaming transform") {
    +    val brp = new BucketedRandomProjectionLSH()
    +      .setNumHashTables(2)
    +      .setInputCol("keys")
    +      .setOutputCol("values")
    +      .setBucketLength(1.0)
    +      .setSeed(12345)
    +    val brpModel = brp.fit(dataset)
    +
    +    testTransformer[Tuple1[Vector]](dataset.toDF(), brpModel, "keys", 
"values") {
    +      case Row(_: Vector, values: Seq[_]) =>
    --- End diff --
    
    OK. so I prefer to use simpler code:
    ```
    testTransformer[Tuple1[Vector]](dataset.toDF(), brpModel, "values") {
        case Row(values: Seq[_]) =>
    ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to