Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20087#discussion_r159117741
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
 ---
    @@ -68,6 +68,10 @@ private[hive] trait SaveAsHiveFile extends 
DataWritingCommand {
             .get("mapreduce.output.fileoutputformat.compress.type"))
         }
     
    +    // Set compression by priority
    +    HiveOptions.getHiveWriteCompression(fileSinkConf.getTableInfo, 
sparkSession.sessionState.conf)
    +      .foreach { case (compression, codec) => hadoopConf.set(compression, 
codec) }
    --- End diff --
    
    This will not be affected by `hive.exec.compress.output`? Could you do an 
investigation the relation of this setting with the codes from line 57 to line 
69?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to