Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20135#discussion_r159227959
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -58,7 +58,7 @@ case class Concat(children: Seq[Expression]) extends
Expression {
} else {
val childTypes = children.map(_.dataType)
if (childTypes.exists(tpe => !Seq(StringType,
BinaryType).contains(tpe))) {
- TypeCheckResult.TypeCheckFailure(
+ return TypeCheckResult.TypeCheckFailure(
s"input to function $prettyName should have StringType or
BinaryType, but it's " +
--- End diff --
This is not related to this pr though, this might be a bug I left in #19977.
(Since branch-2.3 has already been cut out, is it better to split this from
this pr and backport into branch-2.3? @gatorsmile).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
