Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20057#discussion_r159262664
  
    --- Diff: docs/sql-programming-guide.md ---
    @@ -1339,6 +1339,13 @@ the following case-insensitive options:
          This is a JDBC writer related option. When 
<code>SaveMode.Overwrite</code> is enabled, this option causes Spark to 
truncate an existing table instead of dropping and recreating it. This can be 
more efficient, and prevents the table metadata (e.g., indices) from being 
removed. However, it will not work in some cases, such as when the new data has 
a different schema. It defaults to <code>false</code>. This option applies only 
to writing.
        </td>
       </tr>
    +  
    +  <tr>
    +    <td><code>cascadeTruncate</code></td>
    +    <td>
    +        This is a JDBC writer related option. If enabled and supported by 
the JDBC database (PostgreSQL and Oracle at the moment), this options allows 
execution of a <code>TRUNCATE TABLE t CASCADE</code>. This will affect other 
tables, and thus should be used with case. This option applies only to writing.
    --- End diff --
    
    Hi, @danielvdende .
    I think you can ignore my comment in previous PR. There were many 
directional comments on that PR and it's not the final one. Your previous PR is 
merged by @gatorsmile .
    
    For me, I also still don't agree on the default value inside 
`JdbcDialects.scala` in this PR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to