Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20098#discussion_r159338562
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
 ---
    @@ -836,6 +833,20 @@ object ApplicationMaster extends Logging {
     
     }
     
    +object ApplicationMasterUtil {
    --- End diff --
    
    Just add this to the `ApplicationMaster` object instead of creating yet 
another utils object... and also add `private[spark]` to the method there.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to