Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20133#discussion_r159364941
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
    @@ -1366,6 +1388,15 @@ class SparkSqlAstBuilder(conf: SQLConf) extends 
AstBuilder(conf) {
         }
       }
     
    +  private def validateRowFormatFileFormat(
    +      rowFormatCtx: Seq[RowFormatContext],
    +      createFileFormatCtx: Seq[CreateFileFormatContext],
    +      parentCtx: ParserRuleContext): Unit = {
    +    if (rowFormatCtx.size == 1 && createFileFormatCtx.size == 1) {
    +      validateRowFormatFileFormat(rowFormatCtx.head, 
createFileFormatCtx.head, parentCtx)
    --- End diff --
    
    shall we just combine this method and the old `validateRowFormatFileFormat`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to