Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20137#discussion_r159509498
  
    --- Diff: python/pyspark/sql/udf.py ---
    @@ -172,5 +179,5 @@ def asNondeterministic(self):
     
             .. versionadded:: 2.3
             """
    -        self._deterministic = False
    +        self.deterministic = False
    --- End diff --
    
    Can we call it `udfDeterministic` to be consistent with Scala side?
    
    
https://github.com/apache/spark/blob/ff48b1b338241039a7189e7a3c04333b1256fdb3/sql/core/src/main/scala/org/apache/spark/sql/execution/python/UserDefinedPythonFunction.scala#L33
    
    The opposite works fine to me too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to