Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20145#discussion_r159589347
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveUtilsSuite.scala ---
    @@ -42,4 +47,41 @@ class HiveUtilsSuite extends QueryTest with SQLTestUtils 
with TestHiveSingleton
           assert(hiveConf("foo") === "bar")
         }
       }
    +
    +  test("ChildFirstURLClassLoader's parent is null") {
    --- End diff --
    
    I think we can remove it. The below tests case would fail without your PR, 
that proves your patch already.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to