Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20148#discussion_r159592335
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactorySuite.scala
 ---
    @@ -172,10 +172,8 @@ class ExecutorPodFactorySuite extends SparkFunSuite 
with BeforeAndAfter with Bef
           "1", "dummy", "dummy", Seq[(String, String)](), driverPod, 
Map[String, Int]())
     
         assert(executor.getSpec.getInitContainers.size() === 1)
    -    
assert(executor.getSpec.getInitContainers.get(0).getVolumeMounts.get(0).getName
    -      === "secret1-volume")
    -    assert(executor.getSpec.getInitContainers.get(0).getVolumeMounts.get(0)
    -      .getMountPath === "/var/secret1")
    +    assert(SecretVolumeUtils.containerHasVolume(
    --- End diff --
    
    Done. 
https://github.com/apache/spark/pull/20148/commits/93e1d648d56079dcc8bd28bafa7dad4cd9d2dfeb.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to