Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20024#discussion_r159680836
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ---
    @@ -597,6 +619,44 @@ case class Cast(child: Expression, dataType: DataType, 
timeZoneId: Option[String
         """
       }
     
    +  private[this] def codegenWriteArrayElemCode(et: DataType, ctx: 
CodegenContext): String = {
    --- End diff --
    
    It returns a function to write the array elements, maybe a better name is: 
`writeArrayToStringBuilderFunc`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to