Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20013#discussion_r159844819
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
    @@ -848,7 +853,7 @@ private[spark] class AppStatusListener(
         }
     
         stages.foreach { s =>
    -      val key = s.id
    +      val key = Array(s.info.stageId, s.info.attemptId)
    --- End diff --
    
    Use a case class instead?
    Or create a function `xxxKey` and return the Array/Tuple. 
    Using `Array(s.info.stageId, s.info.attemptId)` in several places looks not 
robust enough


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to