Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20166#discussion_r160016007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -228,6 +228,35 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
builder.append("]")
builder.build()
})
+ case MapType(kt, vt, _) =>
+ buildCast[MapData](_, map => {
+ val builder = new UTF8StringBuilder
+ builder.append("[")
+ if (map.numElements > 0) {
+ val keyToUTF8String = castToString(kt)
+ val valueToUTF8String = castToString(vt)
+ builder.append(keyToUTF8String(map.keyArray().get(0,
kt)).asInstanceOf[UTF8String])
--- End diff --
`map.keyArray()` and `map.valueArray` appear many times, we can create 2
local variables for them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
