Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20174#discussion_r160040102
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -106,6 +106,8 @@ case class HashAggregateExec(
// This is a grouped aggregate and the input iterator is empty,
// so return an empty iterator.
Iterator.empty
+ } else if (!hasInput && resultExpressions.isEmpty) {
--- End diff --
`val res = if (!hasInput && (groupingExpressions.nonEmpty ||
resultExpressions.isEmpty)) {`? in line 105? Also, we need to update the
comment in line 106.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
