Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13599#discussion_r160069131
  
    --- Diff: 
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
    @@ -29,7 +30,10 @@ import org.apache.spark._
     import org.apache.spark.internal.Logging
     import org.apache.spark.util.{RedirectThread, Utils}
     
    -private[spark] class PythonWorkerFactory(pythonExec: String, envVars: 
Map[String, String])
    +
    +private[spark] class PythonWorkerFactory(var pythonExec: String,
    --- End diff --
    
    Making pythonExec a var is maybe not ideal.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to