Github user advancedxy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20178#discussion_r160076462
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala ---
    @@ -56,6 +56,8 @@ class StageInfo(
         completionTime = Some(System.currentTimeMillis)
       }
     
    +  def attemptNumber(): Int = attemptId
    --- End diff --
    
    If we go this way, I believe it would break source compatibility for 
Developer API.
    
    Code like `new StageInfo(stageId = xx, attemptId = yy, ...)` couldn't by 
compiled any more.
    
    Not sure about binary compatibility


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to