Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/11994
  
    Hi @CodingCat , thanks a lot for your explanation. IIUC, from the code you 
mentioned above, we still need to pass `MetricRegistry` to `Reporter`, 
otherwise how would a reporter report the registered metrics.
    
    In your example, you're using a new `MetricRegistry`, which is empty. I 
don't think this `Reporter` will report anything in `CodeHaleCsvReporter`, 
unless we pass the `MetricRegistry` from `MetricsSystem` to this reporter.
    
    Please correct me if I'm wrong. :)
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to