Github user frydawg524 commented on the pull request:
https://github.com/apache/spark/pull/2684#issuecomment-59568666
We were able to verify this fix on 1.0.2 by running a test benchmark job 6
times before and after the patch.
3/6 tests failed pre-patch and 0/6 failed post-patch.
We verified by checking the number of output part files for each job.
For jobs that failed, when we hit the deadlock, we saw speculation kill and
re-attempt the task.
After doing this N times, the task failed and threw `java.io.IOException:
Failed to save output of task`
Ultimately, this lead to the job missing some indeterminate number of the
output part files (the ones that failed to commit).
After patching, we verified that for our benchmark jobs none of the part
files were missing.
During benchmarking, we noticed a 8.69% decrease in performance as measured
by the average job time from 5 runs, which is at acceptable levels for us.
Let me know if you need any more details.
Thanks Josh!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
