Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20174#discussion_r160301233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -230,6 +236,7 @@ case class HashAggregateExec( | private void $doAgg() throws java.io.IOException { | // initialize aggregation buffer | $initBufVar + | $hasInput = false; --- End diff -- btw, if `resultExpressions` is empty, we need to check `hasInput`? It seems it is ok to return an empty iterator in that case?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org