Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2834#discussion_r19045505
--- Diff: examples/src/main/python/sql.py ---
@@ -48,7 +48,7 @@
# A JSON dataset is pointed to by path.
# The path can be either a single text file or a directory storing
text files.
- path = os.environ['SPARK_HOME'] +
"examples/src/main/resources/people.json"
+ path = os.path.join(os.environ['SPARK_HOME'],
"examples/src/main/resources/people.json")
--- End diff --
I think the `os.path.join` is fine; I think it's more clear / less brittle.
If it turns out that we do need to make changes to the path separator in order
to support Windows, then using `os.path.join` makes it easier to spot where
path construction is taking place in order to find the code that needs to be
changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
