Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20192#discussion_r160502618
  
    --- Diff: 
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
    @@ -0,0 +1,97 @@
    +#!/bin/bash
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# echo commands to the terminal output
    +set -ex
    +
    +# Check whether there is a passwd entry for the container UID
    +myuid=$(id -u)
    +mygid=$(id -g)
    +uidentry=$(getent passwd $myuid)
    +
    +# If there is no passwd entry for the container UID, attempt to create one
    +if [ -z "$uidentry" ] ; then
    +    if [ -w /etc/passwd ] ; then
    +        echo "$myuid:x:$myuid:$mygid:anonymous uid:$SPARK_HOME:/bin/false" 
>> /etc/passwd
    +    else
    +        echo "Container ENTRYPOINT failed to add passwd entry for 
anonymous UID"
    +    fi
    +fi
    +
    +SPARK_K8S_CMD="$1"
    +if [ -z "$SPARK_K8S_CMD" ]; then
    +  echo "No command to execute has been provided." 1>&2
    --- End diff --
    
    You can do that with `docker container create --entrypoint blah`, right? 
Otherwise you have to add code here to specify what command to run when no 
arguments are provided. I'd rather have a proper error, since the entry point 
is tightly coupled with the submission code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to