Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/20096#discussion_r160570055
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceSuite.scala
---
@@ -49,28 +52,37 @@ abstract class KafkaSourceTest extends StreamTest with
SharedSQLContext {
override val streamingTimeout = 30.seconds
+ protected val brokerProps = Map[String, Object]()
+
override def beforeAll(): Unit = {
super.beforeAll()
- testUtils = new KafkaTestUtils
+ testUtils = new KafkaTestUtils(brokerProps)
testUtils.setup()
}
override def afterAll(): Unit = {
if (testUtils != null) {
testUtils.teardown()
testUtils = null
- super.afterAll()
}
+ super.afterAll()
}
protected def makeSureGetOffsetCalled = AssertOnQuery { q =>
// Because KafkaSource's initialPartitionOffsets is set lazily, we
need to make sure
- // its "getOffset" is called before pushing any data. Otherwise,
because of the race contion,
+ // its "getOffset" is called before pushing any data. Otherwise,
because of the race contOOion,
--- End diff --
I remember wondering this morning why my command-O key sequence wasn't
working... I guess this is where it went.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
