Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19885#discussion_r160617532
  
    --- Diff: 
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
 ---
    @@ -357,6 +357,41 @@ class ClientSuite extends SparkFunSuite with Matchers {
         sparkConf.get(SECONDARY_JARS) should be (Some(Seq(new 
File(jar2.toURI).getName)))
       }
     
    +  private val matching = Seq(
    +    ("files URI match test1", "file:///file1", "file:///file2"),
    +    ("files URI match test2", "file:///c:file1", "file://c:file2"),
    +    ("files URI match test3", "file://host/file1", "file://host/file2"),
    +    ("wasb URI match test", "wasb://bucket1@user", "wasb://bucket1@user/"),
    +    ("hdfs URI match test", "hdfs:/path1", "hdfs:/path1")
    +  )
    +
    +  matching.foreach {
    --- End diff --
    
    nit:
    
    ```
    matching.foreach { t => 
    ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to