Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2743#discussion_r19051234
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -63,9 +64,12 @@ private[spark] class PythonRDD(
val localdir = env.blockManager.diskBlockManager.localDirs.map(
f => f.getPath()).mkString(",")
envVars += ("SPARK_LOCAL_DIRS" -> localdir) // it's also used in
monitor thread
- if (reuse_worker) {
+ if (reuseWorker) {
envVars += ("SPARK_REUSE_WORKER" -> "1")
}
+ if (!memoryLimit.isEmpty) {
+ envVars += ("PYSPARK_WORKER_MEMORY_LIMIT" -> memoryLimit)
--- End diff --
Why do we need both an environment variable and the config? Can the python
get the config value? Elsewhere in Spark we've had to worry about the
precedence order if people set both, and it would be good if we could avoid
this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
