Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20228#discussion_r160866670
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala
 ---
    @@ -140,8 +140,8 @@ class GlobalTempViewSuite extends QueryTest with 
SharedSQLContext {
     
           
assert(spark.catalog.listTables(globalTempDB).collect().toSeq.map(_.name) == 
Seq("v1", "v2"))
         } finally {
    -      spark.catalog.dropTempView("v1")
    -      spark.catalog.dropGlobalTempView("v2")
    +      spark.catalog.dropGlobalTempView("v1")
    +      spark.catalog.dropTempView("v2")
    --- End diff --
    
    Hi, @xubo245 .
    Could you split the bug and new improvement into two separate PR?
    Then, your PR will get reviews more easily.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to