Github user smurakozi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20203#discussion_r161009520
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSetBlacklistSuite.scala ---
    @@ -110,7 +131,13 @@ class TaskSetBlacklistSuite extends SparkFunSuite {
           .set(config.MAX_TASK_ATTEMPTS_PER_NODE, 3)
           .set(config.MAX_FAILURES_PER_EXEC_STAGE, 2)
           .set(config.MAX_FAILED_EXEC_PER_NODE_STAGE, 3)
    -    val taskSetBlacklist = new TaskSetBlacklist(conf, stageId = 0, new 
SystemClock())
    +    val clock = new ManualClock
    +
    +    val attemptId = 0
    +    val taskSetBlacklist = new TaskSetBlacklist(
    +      listenerBusMock, conf, stageId = 0, stageAttemptId = attemptId, 
clock = clock)
    +
    +    clock.setTime(0)
    --- End diff --
    
    You should set the time to a new value before each call of 
taskSetBlacklist.updateBlacklistForFailedTask to see that the events on the 
listenerbus has the correct time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to