Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20223#discussion_r161022921
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -137,7 +139,9 @@ public void testInProcessLauncher() throws Exception {
// Here DAGScheduler is stopped, while
SparkContext.clearActiveContext may not be called yet.
// Wait for a reasonable amount of time to avoid creating two active
SparkContext in JVM.
--- End diff --
It's not that 500ms is not reasonable, it's that this code will return more
quickly when the context shuts down in under 500ms, have a longer grace period
in case it ever takes more than 500ms, and fail the test here if the context
does not shut down.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
