Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20167#discussion_r161074854
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
 ---
    @@ -80,10 +80,27 @@ trait MesosSchedulerUtils extends Logging {
         }
         
fwInfoBuilder.setHostname(Option(conf.getenv("SPARK_PUBLIC_DNS")).getOrElse(
           conf.get(DRIVER_HOST_ADDRESS)))
    +    conf.getOption("spark.mesos.principal.file")
    --- End diff --
    
    Why is it necessary to read the principal from a file? It's not a really 
sensitive parameter, and can be provided with `--conf` with no issues.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to