Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/2838#discussion_r19057007
--- Diff: python/pyspark/worker.py ---
@@ -57,7 +57,7 @@ def main(infile, outfile):
boot_time = time.time()
split_index = read_int(infile)
if split_index == -1: # for unit tests
- return
--- End diff --
The main() is called in a loop after re-use patch, so 'return' will not let
the worker exit, this break the assumption that hold before the patch.
A better approach may be remove this special cases, and rewrite the test
cases without any special treatments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
