Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20248#discussion_r161240770
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -1023,7 +1023,12 @@ case class ShowCreateTableCommand(table:
TableIdentifier) extends RunnableComman
val serdeProps = metadata.storage.properties.map {
case (key, value) =>
- s"'${escapeSingleQuotedString(key)}' =
'${escapeSingleQuotedString(value)}'"
+ val escapedValue = if (value.length == 1 && (value.head < 32 ||
value.head > 126)) {
--- End diff --
I think you want `Character.isISOControl` here. But this is a bit hacky as
you're here hard-coding assumptions about the encoding. Why print non-printable
chars, and why octal? what goes wrong?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
