Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5475#discussion_r161254105
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -297,4 +298,21 @@ class CachedTableSuite extends QueryTest {
         sql("Clear CACHE")
         assert(cacheManager.isEmpty)
       }
    +
    +  test("Clear accumulators when uncacheTable to prevent memory leaking") {
    +    val accsSize = Accumulators.originals.size
    +
    +    sql("SELECT key FROM testData LIMIT 10").registerTempTable("t1")
    +    sql("SELECT key FROM testData LIMIT 5").registerTempTable("t2")
    --- End diff --
    
    We also need to drop these two temp views after tests


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to