Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20254#discussion_r161365371
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -2873,6 +2873,7 @@ setMethod("intersect",
     #' @rdname except
     #' @export
     #' @note except since 1.4.0
    +#' @note behaviour changed from \code{EXCEPT ALL} to \code{EXCEPT 
DISTINCT} in 2.0.
    --- End diff --
    
    I don't mind it either way, but to note:
    - r doc order and whitespace is significant, if you use `#' Note:` you must 
put it after L2856, if you put an extra `#'` ie. empty line that it becomes the 
`Details` section, which might be the right place; see 
http://spark.apache.org/docs/latest/api/R/awaitTermination.html


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to