GitHub user xubo245 opened a pull request:

    https://github.com/apache/spark/pull/20260

     [SPARK-23039][SQL] Finish TODO work in alter table set location.

    
    ## What changes were proposed in this pull request?
     Finish TODO work in alter table set location.
      org.apache.spark.sql.execution.command.DDLSuite#testSetLocation
    
        // TODO(gatorsmile): fix the bug in alter table set location.
        //    if (isUsingHiveMetastore) {
        //    assert(storageFormat.properties.get("path") === expected)
        //   }
    
    fix it by remove newPath = None in 
org.apache.spark.sql.hive.HiveExternalCatalog#restoreDataSourceTable
    ## How was this patch tested?
    
     test("SPARK-23039: check path after SET LOCATION")
    
    Wait for https://github.com/apache/spark/pull/20249

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/spark setLocationTODO

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20260
    
----
commit 76c1813cf6e0e0e0d085cd31dcf1633c80829eff
Author: xubo245 <601450868@...>
Date:   2018-01-13T13:53:52Z

     [SPARK-23039][SQL] Fix the bug in alter table set location.
    
      TOBO work: Fix the bug in alter table set location.
      org.apache.spark.sql.execution.command.DDLSuite#testSetLocation
    
        // TODO(gatorsmile): fix the bug in alter table set location.
        //    if (isUsingHiveMetastore) {
        //    assert(storageFormat.properties.get("path") === expected)
        //   }

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to