Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20224#discussion_r161381362
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -312,6 +313,24 @@ case class InputAdapter(child: SparkPlan) extends 
UnaryExecNode with CodegenSupp
     object WholeStageCodegenExec {
       val PIPELINE_DURATION_METRIC = "duration"
     
    +  private val codegenStageCounter = ThreadLocal.withInitial(new 
Supplier[Integer] {
    --- End diff --
    
    Instead of adding these logics into `object WholeStageCodegenExec`, could 
we just create a new object?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to