Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2780#issuecomment-59661579
@chouqin Thanks for the updates! The updates look good.
One more small comment: Could you please add explicit checks in the unit
tests to make sure the returned splits are distinct? I should have thought of
that earlier.
I'll try some timing tests to make sure the sampling does not take too long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
