Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2844#discussion_r19063363
  
    --- Diff: 
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
    @@ -62,6 +59,20 @@ private[spark] class TorrentBroadcast[T: ClassTag](
        * blocks from the driver and/or other executors.
        */
       @transient private var _value: T = obj
    +  /** The compression codec to use, or None if compression is disabled */
    +  @transient private var compressionCodec: Option[CompressionCodec] = _
    +  /** Size of each block. Default value is 4MB.  This value is only read 
by the broadcaster. */
    +  @transient private var blockSize: Int = _
    --- End diff --
    
    I thought about this and agree that it might be cleaner, but this will 
require more refactoring of other code.  One design goal here was to minimize 
the serialized size of TorrentBroadcast objects, so we can't serialize the 
SparkConf or CompressionCodec instances (which contain SparkConfs).  
SparkEnv.conf determines these values anyways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to