Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2824#discussion_r19066582
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -272,20 +272,38 @@ private[spark] object Utils extends Logging {
       /** Copy all data from an InputStream to an OutputStream */
       def copyStream(in: InputStream,
                      out: OutputStream,
    -                 closeStreams: Boolean = false): Long =
    +                 closeStreams: Boolean = false,
    +                 transferToEnabled: Boolean = true): Long =
    --- End diff --
    
    Thanks Josh, I think I start to know your concern. My previous modification 
may not well control the behavior of `transferTo` in all uses of it, but this 
brings less impact to the current code path. If we'd like to control it in all 
the places, we have to pass and verify the configuration in all the places 
where use `copyStream`, which is not so elegant in some codes which have to to 
get SparkConf. I will think a better way to address this. Thanks a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to