Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19892#discussion_r161684641
  
    --- Diff: python/pyspark/ml/param/__init__.py ---
    @@ -134,6 +134,16 @@ def toListFloat(value):
                     return [float(v) for v in value]
             raise TypeError("Could not convert %s to list of floats" % value)
     
    +    @staticmethod
    +    def toListListFloat(value):
    --- End diff --
    
    We need a test case in `ParamTypeConversionTests` for this new method; see 
`test_list_float` for reference.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to