Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/19224#discussion_r161744616
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonUtils.scala
---
@@ -39,7 +38,7 @@ object JsonUtils {
/**
* Sample JSON RDD as configured by `samplingRatio`.
*/
- def sample(json: RDD[PortableDataStream], options: JSONOptions):
RDD[PortableDataStream] = {
+ def sample[T](json: RDD[T], options: JSONOptions): RDD[T] = {
--- End diff --
nit: consider removing the generic T as not needed:
``` scala
def sample(json: RDD[String], options: JSONOptions): RDD[String]
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
