Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20243#discussion_r161923688
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/sources/ConsoleWriterSuite.scala
 ---
    @@ -0,0 +1,79 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming.sources
    +
    +import java.io.ByteArrayOutputStream
    +
    +import org.apache.spark.sql.execution.streaming.MemoryStream
    +import org.apache.spark.sql.streaming.StreamTest
    +
    +class ConsoleWriterSuite extends StreamTest {
    +  import testImplicits._
    +
    +  test("console") {
    +    val input = MemoryStream[Int]
    +
    +    val captured = new ByteArrayOutputStream()
    +    Console.withOut(captured) {
    +      val query = input.toDF().writeStream.format("console").start()
    +      try {
    +        input.addData(1, 2, 3)
    +        query.processAllAvailable()
    +        input.addData(4, 5, 6)
    +        query.processAllAvailable()
    +        input.addData()
    +        query.processAllAvailable()
    +      } finally {
    +        query.stop()
    +      }
    +    }
    +
    +    assert(captured.toString() ==
    +      """-------------------------------------------
    +        |Batch: 0
    +        |-------------------------------------------
    +        |+-----+
    +        ||value|
    +        |+-----+
    +        ||    1|
    +        ||    2|
    +        ||    3|
    +        |+-----+
    +        |
    +        |-------------------------------------------
    +        |Batch: 1
    +        |-------------------------------------------
    +        |+-----+
    +        ||value|
    +        |+-----+
    +        ||    4|
    +        ||    5|
    +        ||    6|
    +        |+-----+
    +        |
    +        |-------------------------------------------
    +        |Batch: 2
    +        |-------------------------------------------
    +        |+-----+
    +        ||value|
    +        |+-----+
    +        |+-----+
    +        |
    +        |""".stripMargin)
    +  }
    +}
    --- End diff --
    
    Indeed we could. Thanks for writing out the tests!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to