Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20023
LGTM.
One thing we can improve is the golden file test framework. I found we
sometimes repeat the test cases with a config on and off. We should write the
test cases once and list the configs we wanna try, and ask the test framework
to do it. This can be a follow-up.
@mgaido91 thanks for your great work!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
