Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20045#discussion_r162182000
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
---
@@ -246,13 +246,24 @@ class ExpressionParserSuite extends PlanTest {
// Basic window testing.
assertEqual("foo(*) over w1", UnresolvedWindowExpression(func,
WindowSpecReference("w1")))
assertEqual("foo(*) over ()", windowed())
+ assertEqual("foo(*) over (partition by a)", windowed(Seq('a)))
--- End diff --
You shall also cover the `null` cases, such as `foo(*) over (partition by
null)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
