Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19872#discussion_r162235628
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -363,6 +371,21 @@ abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
     
             aggregateOperator
     
    +      case PhysicalAggregation(groupingExpressions, aggExpressions, 
resultExpressions, child)
    +        if aggExpressions.forall(expr => expr.isInstanceOf[PythonUDF]) =>
    +        val udfExpressions = aggExpressions.map(expr => 
expr.asInstanceOf[PythonUDF])
    +
    +        Seq(execution.python.AggregateInPandasExec(
    +          groupingExpressions,
    +          udfExpressions,
    +          resultExpressions,
    +          planLater(child)))
    +
    +      case PhysicalAggregation(groupingExpressions, aggExpressions, 
resultExpressions, child) =>
    --- End diff --
    
    How about `case PhysicalAggregation(_) =>`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to