Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20307#discussion_r162258962
  
    --- Diff: python/pyspark/sql/udf.py ---
    @@ -310,14 +310,22 @@ def registerJavaFunction(self, name, javaClassName, 
returnType=None):
             ...     "javaStringLength", 
"test.org.apache.spark.sql.JavaStringLength", IntegerType())
    --- End diff --
    
    Ah, seems we need to fix `:param returnType:` across all other related APIs 
saying it takes DDL-formatted type string. 
    
    @ueshin, mind opening a minor PR for this - `udf`, `pandas_udf`, 
`registerJavaFunction` and `register`  separately? If you are busy, will do it 
tonight. Doing this here is fine to me too, up to you.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to