Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20305#discussion_r162274134
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala
---
@@ -98,20 +98,7 @@ class HiveSessionStateBuilder(session: SparkSession,
parentState: Option[Session
override def extraPlanningStrategies: Seq[Strategy] =
super.extraPlanningStrategies ++ customPlanningStrategies
- override def strategies: Seq[Strategy] = {
- experimentalMethods.extraStrategies ++
- extraPlanningStrategies ++ Seq(
- FileSourceStrategy,
- DataSourceStrategy(conf),
- SpecialLimits,
- InMemoryScans,
- HiveTableScans,
- Scripts,
- Aggregation,
- JoinSelection,
- BasicOperators
- )
- }
+ override def strategies: Seq[Strategy] = Seq(HiveTableScans,
Scripts) ++ super.strategies
--- End diff --
This breaks the assumption that `experimentalMethods.extraStrategies`
should always run first.
I think we can just do:
```
override def extraPlanningStrategies: Seq[Strategy] =
super.extraPlanningStrategies ++ customPlanningStrategies ++
Seq(HiveTableScans, Scripts)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
