Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2828#issuecomment-59812443
As a general principle, you should use the most private access modifiers
that are sufficient. We can always make methods / fields _more_ visible, but
it's much harder to remove / change functionality once it's been exposed to
other components.
W.r.t. refactoring, I agree with Mark: a large-scale refactoring of access
modifiers should happen in a separate PR, not here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
