GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/20316

    [SPARK-23149][SQL] polish ColumnarBatch

    ## What changes were proposed in this pull request?
    
    Several cleanups in `ColumnarBatch`
    * remove `schema`. The `ColumnVector`s inside `ColumnarBatch` already have 
the data type information, we don't need this `schema`.
    * remove `capacity`. `ColumnarBatch` is just a wrapper of `ColumnVector`s, 
not builders, it doesn't need a capacity property.
    * remove `DEFAULT_BATCH_SIZE`. As a wrapper, `ColumnarBatch` can't decide 
the batch size, it should be decided by the reader, e.g. parquet reader, orc 
reader, cached table reader.
    
    ## How was this patch tested?
    
    existing tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark columnar-batch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20316
    
----
commit 669948305fbf87420c0458e3701902c0f1f78205
Author: Wenchen Fan <wenchen@...>
Date:   2018-01-18T14:58:03Z

    polish ColumnarBatch

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to