Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/19285#discussion_r162548052 --- Diff: core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala --- @@ -233,17 +235,13 @@ private[spark] class MemoryStore( } if (keepUnrolling) { - // We successfully unrolled the entirety of this block - val arrayValues = vector.toArray - vector = null - val entry = - new DeserializedMemoryEntry[T](arrayValues, SizeEstimator.estimate(arrayValues), classTag) - val size = entry.size + // get the precise size + val size = estimateSize(true) --- End diff -- It seems deserialized values do not have a **precise** size, even for `SizeEstimator.estimate(arrayValues)`. This would be confused.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org