Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20087#discussion_r162673245
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala
---
@@ -260,17 +282,21 @@ class CompressionCodecSuite extends TestHiveSingleton
with ParquetTest with Befo
def checkForTableWithoutCompressProp(format: String, compressCodecs:
List[String]): Unit = {
Seq(true, false).foreach { isPartitioned =>
Seq(true, false).foreach { convertMetastore =>
- checkTableCompressionCodecForCodecs(
- format,
- isPartitioned,
- convertMetastore,
- compressionCodecs = compressCodecs,
- tableCompressionCodecs = List(null)) {
- case (tableCompressionCodec, sessionCompressionCodec,
realCompressionCodec, tableSize) =>
- // Always expect session-level take effect
- assert(sessionCompressionCodec == realCompressionCodec)
- assert(checkTableSize(format, sessionCompressionCodec,
- isPartitioned, convertMetastore, tableSize))
+ Seq(true, false).foreach { usingCTAS =>
+ checkTableCompressionCodecForCodecs(
+ format,
+ isPartitioned,
+ convertMetastore,
+ usingCTAS,
+ compressionCodecs = compressCodecs,
+ tableCompressionCodecs = List(null)) {
+ case
+ (tableCompressionCodec, sessionCompressionCodec,
realCompressionCodec, tableSize) =>
+ // Always expect session-level take effect
+ assert(sessionCompressionCodec == realCompressionCodec)
+ assert(checkTableSize(format, sessionCompressionCodec,
+ isPartitioned, convertMetastore, usingCTAS, tableSize))
--- End diff --
```
assert(checkTableSize(
format, sessionCompressionCodec, isPartitioned, convertMetastore,
usingCTAS, tableSize))
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
