Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2789#discussion_r19121441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -64,6 +64,23 @@ abstract class BinaryArithmetic extends BinaryExpression
{
}
left.dataType
}
+
+ override def eval(input: Row): Any = {
+ val evalE1 = left.eval(input)
+ if(evalE1 == null) {
+ null
+ } else {
+ val evalE2 = right.eval(input)
+ if (evalE2 == null) {
+ null
+ } else {
+ evalInternal(evalE1, evalE2)
+ }
+ }
+ }
+
+ def evalInternal(evalE1: EvaluatedType, evalE2: EvaluatedType): Any =
+ sys.error(s"Unsupported binary operation")
--- End diff --
Oh I see because of the other binary expressions that also override eval.
We should at least leave a note by changing the Exception to "BinaryExpressions
must either override eval or evalInternal".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
